Define Python_FIND_VIRTUALENV in addition to Python3_FIND_VIRTUALENV #4004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The fails in the CI are unrelated to the changes in this PR and they show up in other PR as well. |
dbabokin
force-pushed
the
python_venv
branch
from
dde987a to
c0d8a2e
Compare
|
All green. Need someone to review and approve. |
|
Thanks @dbabokin! Can you resolve the conflicts thus we can merge this? I guess we could also set the one option based on the other a little deeper in CMake world? But this also works for me. |
ScottTodd
reviewed
Apr 30, 2025
MLIR searches for both Python3 and Python. If both variables are not defined equally and there multiple python version on the system, CMake may behave really weirdly. More details here: llvm/llvm-project#126162
|
I've updated the PR, sorry for such long response time. The fix seem to be still relevant. CI fails are really weird - looks like Github a broken 😨 I suggest re-running CI jobs. |
Indeed. They succeeded on a retry. |
ScottTodd
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MLIR searches for both Python3 and Python. If both variables are not defined equally and there multiple python versions on the system, CMake may behave really weirdly.
More details here: llvm/llvm-project#126162
So I grepped for all instances of
Python3_FIND_VIRTUALENVand added similarPython_FIND_VIRTUALENVdefinition.